From 79657a7b1fc5a4441a16d5f9766b533ad101e7d0 Mon Sep 17 00:00:00 2001 From: Adam Ladachowski Date: Mon, 16 Feb 2026 10:15:34 +0100 Subject: [PATCH] Fix lint errors in OAuth routes - Break long SVG path lines in login pages (E501) - Remove unused request parameter from callbacks (ARG001) - Add noqa for too-many-returns in OAuth callbacks (PLR0911) - Remove unused CORSMiddleware import - Fix type narrowing in logout redirect Co-Authored-By: Claude Opus 4.5 --- tensors/server/__init__.py | 1 - tensors/server/auth_routes.py | 16 +++++++++++----- tensors/server/comfyui_routes.py | 14 ++++++++++++-- 3 files changed, 23 insertions(+), 8 deletions(-) diff --git a/tensors/server/__init__.py b/tensors/server/__init__.py index e1a829d..ea88b75 100644 --- a/tensors/server/__init__.py +++ b/tensors/server/__init__.py @@ -7,7 +7,6 @@ from contextlib import asynccontextmanager from typing import TYPE_CHECKING from fastapi import Depends, FastAPI -from fastapi.middleware.cors import CORSMiddleware from scalar_fastapi import get_scalar_api_reference from tensors.config import get_server_api_key diff --git a/tensors/server/auth_routes.py b/tensors/server/auth_routes.py index e25c948..801ea7e 100644 --- a/tensors/server/auth_routes.py +++ b/tensors/server/auth_routes.py @@ -10,7 +10,7 @@ import time import urllib.parse import httpx -from fastapi import APIRouter, Cookie, HTTPException, Query, Request, status +from fastapi import APIRouter, Cookie, Query, Request, status from fastapi.responses import HTMLResponse, JSONResponse, RedirectResponse, Response router = APIRouter(tags=["Auth"]) @@ -185,7 +185,14 @@ LOGIN_PAGE_HTML = """ {{ERROR}} Sign in with GitHub @@ -258,8 +265,7 @@ async def github_auth( @router.get("/auth/callback") -async def github_callback( - request: Request, +async def github_callback( # noqa: PLR0911 code: str | None = None, state: str | None = None, ) -> Response: @@ -412,7 +418,7 @@ async def auth_success() -> HTMLResponse: @router.get("/auth/logout") async def logout(return_url: str | None = Query(None)) -> Response: """Clear session and redirect.""" - redirect_to = return_url if _is_valid_redirect_url(return_url) else "/auth/login" + redirect_to = return_url if return_url and _is_valid_redirect_url(return_url) else "/auth/login" response = RedirectResponse(url=redirect_to, status_code=status.HTTP_303_SEE_OTHER) response.delete_cookie("tensors_session") return response diff --git a/tensors/server/comfyui_routes.py b/tensors/server/comfyui_routes.py index 3c488e4..e705644 100644 --- a/tensors/server/comfyui_routes.py +++ b/tensors/server/comfyui_routes.py @@ -169,7 +169,14 @@ LOGIN_PAGE_HTML = """ {{ERROR}} Sign in with GitHub @@ -226,7 +233,10 @@ async def github_auth(request: Request) -> Response: @router.get("/comfy/auth/callback") -async def github_callback(request: Request, code: str | None = None, state: str | None = None) -> Response: +async def github_callback( # noqa: PLR0911 + code: str | None = None, + state: str | None = None, +) -> Response: """Handle GitHub OAuth callback.""" # Verify state if not state or state not in _oauth_states: